Skip to content

DM-50973: use a map file to reduce the request size#88

Merged
wguanicedew merged 6 commits into
mainfrom
tickets/DM-50973
May 21, 2025
Merged

DM-50973: use a map file to reduce the request size#88
wguanicedew merged 6 commits into
mainfrom
tickets/DM-50973

Conversation

@wguanicedew
Copy link
Copy Markdown
Contributor

@wguanicedew wguanicedew commented May 18, 2025 •
edited
Loading

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 5.00000% with 38 lines in your changes missing coverage. Please review.

Project coverage is 25.76%. Comparing base (7d70c6a) to head (8bf9db4).
Report is 7 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
python/lsst/ctrl/bps/panda/utils.py 0.00% 34 Missing ⚠️
python/lsst/ctrl/bps/panda/panda_service.py 33.33% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
- Coverage   26.48%   25.76%   -0.73%     
==========================================
  Files           9        9              
  Lines         789      815      +26     
  Branches      132      137       +5     
==========================================
+ Hits          209      210       +1     
- Misses        571      596      +25     
  Partials        9        9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zhaoyuyoung
zhaoyuyoung reviewed May 19, 2025
View reviewed changes
Comment thread python/lsst/ctrl/bps/panda/edgenode/cmd_line_decoder.py
zhaoyuyoung
zhaoyuyoung reviewed May 19, 2025
View reviewed changes
Comment thread python/lsst/ctrl/bps/panda/edgenode/cmd_line_decoder.py
MichelleGower
MichelleGower approved these changes May 20, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@MichelleGower MichelleGower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple comments. I'm not sure I followed all the changes that it would still work if wanting events but not order id mapping. It would be nice to have unit tests to check dependencies match those in the GenericWorkflow (with order id mapping and without). Merge approved.

Comment thread python/lsst/ctrl/bps/panda/edgenode/cmd_line_decoder.py
Comment thread python/lsst/ctrl/bps/panda/edgenode/cmd_line_decoder.py Outdated
Comment thread python/lsst/ctrl/bps/panda/utils.py Outdated
Comment thread python/lsst/ctrl/bps/panda/utils.py Outdated
Comment thread python/lsst/ctrl/bps/panda/utils.py Outdated
@wguanicedew
Copy link
Copy Markdown
Contributor Author

wguanicedew commented May 21, 2025

I have updated the codes based on the comments. I will do another test with different types of jobs before the merge.

@wguanicedew
Copy link
Copy Markdown
Contributor Author

wguanicedew commented May 21, 2025

All tests are ok. Will merge it.

@wguanicedew wguanicedew merged commit 74a5378 into main May 21, 2025
16 of 18 checks passed
@wguanicedew wguanicedew deleted the tickets/DM-50973 branch May 21, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhaoyuyoung zhaoyuyoung zhaoyuyoung left review comments

@MichelleGower MichelleGower MichelleGower approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wguanicedew @zhaoyuyoung @MichelleGower